diff options
| author | Ahmed Abdelhalim <[email protected]> | 2025-08-11 00:32:04 +0200 |
|---|---|---|
| committer | Ahmed Abdelhalim <[email protected]> | 2025-08-11 00:32:04 +0200 |
| commit | e02325cde6624243f3498226301018dca037c9cd (patch) | |
| tree | e3f1656e50060064da5b3b062fef33263fd90072 /roles/network/tasks | |
| parent | 6bca3c0f2a68b4c4a2a877de2fb8c343e8fda4f9 (diff) | |
Simplify playbook by requiring the required_for_boot tag on roles
Instead of optimizing for task execution for boot, it's simpler and
almost as equally safe (if not even more) to require the role for boot
instead of requiring each of it's needed tasks.
This will also prevent having internal bugs because a set fact wasn't
required for boot and didn't add the info
(similar to the fix in commit: 9f72c58)
Diffstat (limited to 'roles/network/tasks')
| -rw-r--r-- | roles/network/tasks/install-archlinux.yml | 1 | ||||
| -rw-r--r-- | roles/network/tasks/install-debian.yml | 4 | ||||
| -rw-r--r-- | roles/network/tasks/main.yml | 6 |
3 files changed, 0 insertions, 11 deletions
diff --git a/roles/network/tasks/install-archlinux.yml b/roles/network/tasks/install-archlinux.yml index 788febea..b238d0cb 100644 --- a/roles/network/tasks/install-archlinux.yml +++ b/roles/network/tasks/install-archlinux.yml @@ -5,4 +5,3 @@ name: "{{ network_packages }}" state: "present" update_cache: true - tags: [required_for_boot] diff --git a/roles/network/tasks/install-debian.yml b/roles/network/tasks/install-debian.yml index 74c527d5..6b5455a8 100644 --- a/roles/network/tasks/install-debian.yml +++ b/roles/network/tasks/install-debian.yml @@ -5,7 +5,6 @@ pkg: "{{ network_packages }}" state: "present" update_cache: true - tags: [required_for_boot] - name: "Set network_default_services facts" ansible.builtin.set_fact: @@ -14,7 +13,6 @@ - "avahi-daemon" - "networking" - "wpa_supplicant" - tags: [required_for_boot] - name: "Stop/Disable conflicting services" become: true @@ -34,7 +32,6 @@ changed_when: true when: ansible_is_chroot # noqa: command-instead-of-module module doesn't work inside chroot - tags: [required_for_boot] - name: "Ensure avahi packages are removed" become: true @@ -45,4 +42,3 @@ state: "absent" autoremove: true purge: true - tags: [required_for_boot] diff --git a/roles/network/tasks/main.yml b/roles/network/tasks/main.yml index cb8f1fd9..54b0a9ed 100644 --- a/roles/network/tasks/main.yml +++ b/roles/network/tasks/main.yml @@ -7,7 +7,6 @@ content: | {{ hostname }} when: hostname is defined - tags: [required_for_boot] - name: "Configure /etc/hosts" become: true @@ -22,15 +21,12 @@ ff02::2 ip6-allrouters when: hostname is defined # Not required for boot - tags: [] - name: "Include OS-specific variables" ansible.builtin.include_vars: "{{ ansible_os_family | lower }}.yml" - tags: [required_for_boot] - name: "Install OS-specific packages" ansible.builtin.include_tasks: "install-{{ ansible_os_family | lower }}.yml" - tags: [required_for_boot] - name: "(chroot): Ensure network_services are enabled" ansible.builtin.command: @@ -39,11 +35,9 @@ with_items: "{{ network_services }}" when: ansible_is_chroot # noqa: command-instead-of-module module doesn't work inside chroot - tags: [required_for_boot] - name: "Configure NetworkManager" become: true - tags: [required_for_boot] notify: - "Reload systemd" - "Restart NetworkManager" |