Fix running rpi configuration as root always

The dotfile/vim/password_store required to run as user with root
permissions, that's why reverting these changes on rpi and resolving to
using a more normal role (in pihole where it was broken)

3 files changed, 10 insertions, 1 deletions

diff --git a/configure.yml b/configure.yml
index c6d78f08..b8fdba40 100644
--- a/configure.yml
+++ b/configure.yml
@@ -46,7 +46,6 @@
   gather_facts: true
   hosts:
     - rpi5.local
-  become: true
   roles:
     - role: "locales"
     - role: "timezone"
diff --git a/roles/pihole/handlers/main.yml b/roles/pihole/handlers/main.yml
index dca1ef52..68f4f3a0 100644
--- a/roles/pihole/handlers/main.yml
+++ b/roles/pihole/handlers/main.yml
@@ -1,15 +1,18 @@
 ---
 - name: "Restart pihole"
+  become: true
   ansible.builtin.systemd_service:
     name: "pihole-FTL"
     state: "restarted"
 
 - name: "Restart systemd-resolved"
+  become: true
   ansible.builtin.systemd_service:
     name: "systemd-resolved"
     state: "restarted"
 
 - name: "Restart NetworkManager"
+  become: true
   ansible.builtin.systemd_service:
     name: "NetworkManager"
     state: "restarted"
diff --git a/roles/pihole/tasks/main.yml b/roles/pihole/tasks/main.yml
index 0d21fc07..a45a1482 100644
--- a/roles/pihole/tasks/main.yml
+++ b/roles/pihole/tasks/main.yml
@@ -16,12 +16,14 @@
   when: pihole_dhcp_enabled
 
 - name: "Crete Pi-hole user"
+  become: true
   ansible.builtin.user:
     name: "pihole"
     system: true
     shell: "/usr/sbin/nologin"
 
 - name: "Create Pi-hole directories"
+  become: true
   ansible.builtin.file:
     path: "{{ item }}"
     state: "directory"
@@ -33,6 +35,7 @@
     - "/var/log/pihole"
 
 - name: "Create Pi-hole configuration file"
+  become: true
   ansible.builtin.template:
     src: "pihole.toml.j2"
     dest: "/etc/pihole/pihole.toml"
@@ -58,6 +61,7 @@
   when: not pihole_binary.stat.exists
 
 - name: "Run Pi-hole installer"
+  become: true
   ansible.builtin.command:
     cmd: "/tmp/install_pihole.sh --unattended"
   register: pihole_install
@@ -72,6 +76,7 @@
     var: pihole_install.stdout
 
 - name: "Ensure Pi-hole started/enabled"
+  become: true
   ansible.builtin.systemd_service:
     name: "pihole-FTL"
     enabled: true
@@ -79,11 +84,13 @@
     daemon_reload: true
 
 - name: "Update Pi-hole blocklists"
+  become: true
   ansible.builtin.command:
     cmd: "pihole -g"
   changed_when: false
 
 - name: "Configure pihole as system DNS"
+  become: true
   tags:
     # linking the systemd run files fails in molecule tests
     # This is not relevant to the testing itself, so it's safe to ignore