From e02325cde6624243f3498226301018dca037c9cd Mon Sep 17 00:00:00 2001
From: Ahmed Abdelhalim <pm@a14m.dev>
Date: Mon, 11 Aug 2025 00:32:04 +0200
Subject: Simplify playbook by requiring the required_for_boot tag on roles

Instead of optimizing for task execution for boot, it's simpler and
almost as equally safe (if not even more) to require the role for boot
instead of requiring each of it's needed tasks.
This will also prevent having internal bugs because a set fact wasn't
required for boot and didn't add the info
(similar to the fix in commit: 9f72c58)
---
 roles/user/tasks/install-archlinux.yml | 1 -
 roles/user/tasks/install-debian.yml    | 1 -
 roles/user/tasks/main.yml              | 8 --------
 3 files changed, 10 deletions(-)

(limited to 'roles/user')

diff --git a/roles/user/tasks/install-archlinux.yml b/roles/user/tasks/install-archlinux.yml
index 0813c342..15abe034 100644
--- a/roles/user/tasks/install-archlinux.yml
+++ b/roles/user/tasks/install-archlinux.yml
@@ -5,4 +5,3 @@
     name: "sudo"
     state: "present"
     update_cache: true
-  tags: [required_for_boot]
diff --git a/roles/user/tasks/install-debian.yml b/roles/user/tasks/install-debian.yml
index d70fd3ce..d602e471 100644
--- a/roles/user/tasks/install-debian.yml
+++ b/roles/user/tasks/install-debian.yml
@@ -5,4 +5,3 @@
     name: "sudo"
     state: "present"
     update_cache: true
-  tags: [required_for_boot]
diff --git a/roles/user/tasks/main.yml b/roles/user/tasks/main.yml
index eb38f95e..71deaeed 100644
--- a/roles/user/tasks/main.yml
+++ b/roles/user/tasks/main.yml
@@ -1,18 +1,15 @@
 ---
 - name: "Install OS-specific packages"
   ansible.builtin.include_tasks: "install-{{ ansible_os_family | lower }}.yml"
-  tags: [required_for_boot]
 
 - name: "Set sudo group fact"
   ansible.builtin.set_fact:
     # noqa var-naming[no-role-prefix] the sudo group is global and better named this way than user_sudo_group
     sudo_group: "sudo"
-  tags: [required_for_boot]
 
 - name: "Set user groups fact"
   ansible.builtin.set_fact:
     user_groups: "{{ ([username, sudo_group] + user_groups) | unique }}"
-  tags: [required_for_boot]
 
 - name: "Configure permissions for group: {{ sudo_group }}"
   become: true
@@ -23,7 +20,6 @@
     nopassword: false
     sudoers_path: "/etc/sudoers.d"
     state: present
-  tags: [required_for_boot]
 
 - name: "Ensure user groups are created"
   become: true
@@ -31,7 +27,6 @@
     name: "{{ item }}"
     state: "present"
   with_items: "{{ user_groups }}"
-  tags: [required_for_boot]
 
 # noqa var-naming[no-role-prefix] username is more understandable than user_name
 - name: "Create user: {{ username }}"
@@ -47,7 +42,6 @@
     update_password: "on_create"
   register: user
   notify: "Require password change"
-  tags: [required_for_boot]
 
 - name: "Create user ssh directory"
   ansible.builtin.file:
@@ -55,7 +49,6 @@
     mode: "0700"
     owner: "{{ username }}"
     state: "directory"
-  tags: [required_for_boot]
 
 - name: "Add user ssh authorized_keys"
   ansible.builtin.copy:
@@ -64,4 +57,3 @@
     owner: "{{ username }}"
     content: |
       {{ user_public_keys | join('\n') }}
-  tags: [required_for_boot]
-- 
cgit v1.2.3