From 97c97e7b9880a90b2e54dd2b5f02aaf65824fb1f Mon Sep 17 00:00:00 2001
From: Ahmed Abdelhalim <pm@a14m.dev>
Date: Fri, 3 Jul 2026 23:43:17 +0200
Subject: Refactor pve roles to create storage separately

---
 roles/pve/defaults/main.yml       | 2 --
 roles/pve/meta/argument_specs.yml | 8 --------
 roles/pve/tasks/main.yml          | 8 --------
 3 files changed, 18 deletions(-)

(limited to 'roles/pve')

diff --git a/roles/pve/defaults/main.yml b/roles/pve/defaults/main.yml
index c2bca151..c9047655 100644
--- a/roles/pve/defaults/main.yml
+++ b/roles/pve/defaults/main.yml
@@ -2,5 +2,3 @@
 pve_repo: "no-subscription"
 pve_admin_user: "admin"
 pve_admin_password: "changeme"
-pve_lvm_device: "/dev/sda4"
-pve_lvm_vg_name: "pve"
diff --git a/roles/pve/meta/argument_specs.yml b/roles/pve/meta/argument_specs.yml
index ab9f22c6..195ca146 100644
--- a/roles/pve/meta/argument_specs.yml
+++ b/roles/pve/meta/argument_specs.yml
@@ -17,11 +17,3 @@ argument_specs:
         type: "str"
         description: "PVE realm admin password"
         default: "changeme"
-      pve_lvm_device:
-        type: "str"
-        description: "Block device for PVE LVM volume group (e.g. /dev/sda4)"
-        default: "/dev/sda4"
-      pve_lvm_vg_name:
-        type: "str"
-        description: "LVM volume group name — PVE auto-detects VG named 'pve' as local-lvm storage"
-        default: "pve"
diff --git a/roles/pve/tasks/main.yml b/roles/pve/tasks/main.yml
index 7a314325..30304e85 100644
--- a/roles/pve/tasks/main.yml
+++ b/roles/pve/tasks/main.yml
@@ -61,14 +61,6 @@
   tags:
     - "molecule-notest"
 
-- name: "Create LVM volume group for PVE storage"
-  become: true
-  ansible.builtin.command:
-    cmd: "vgcreate {{ pve_lvm_vg_name }} {{ pve_lvm_device }}"
-    creates: "/dev/{{ pve_lvm_vg_name }}"
-  tags:
-    - "molecule-notest"
-
 - name: "Enable and start Proxmox VE services"
   become: true
   ansible.builtin.systemd_service:
-- 
cgit v1.2.3