From 9407eecc04c703c1bfc413efda93c41ae305689f Mon Sep 17 00:00:00 2001
From: Ahmed Abdelhalim <pm@a14m.dev>
Date: Mon, 6 Jul 2026 17:17:50 +0200
Subject: Fix network setup on pve

---
 roles/network/meta/argument_specs.yml                   |  4 ++--
 roles/network/tasks/main.yml                            |  4 ++--
 roles/network/templates/bridge.nmconnection.j2          |  4 ++--
 roles/network/templates/eth0-connection.nmconnection.j2 | 12 +++++++-----
 4 files changed, 13 insertions(+), 11 deletions(-)

(limited to 'roles/network')

diff --git a/roles/network/meta/argument_specs.yml b/roles/network/meta/argument_specs.yml
index f85318a8..0c9f74fe 100644
--- a/roles/network/meta/argument_specs.yml
+++ b/roles/network/meta/argument_specs.yml
@@ -30,7 +30,7 @@ argument_specs:
       network_ipv6_dns:
         type: "str"
         description: "The network IP(4) gateway to configure when provided"
-      network_bridge:
+      network_bridge_interface:
         type: "str"
-        description: "Bridge interface name — when set, ethernet becomes bridge port and bridge connection is created"
+        description: "Physical NIC to enslave as vmbr0 bridge port"
         required: false
diff --git a/roles/network/tasks/main.yml b/roles/network/tasks/main.yml
index 1268b3cd..967a0b30 100644
--- a/roles/network/tasks/main.yml
+++ b/roles/network/tasks/main.yml
@@ -106,11 +106,11 @@
     - name: "Configure bridge connection"
       ansible.builtin.template:
         src: "bridge.nmconnection.j2"
-        dest: "/etc/NetworkManager/system-connections/{{ network_bridge }}.nmconnection"
+        dest: "/etc/NetworkManager/system-connections/vmbr0.nmconnection"
         mode: "0600"
         owner: "root"
         group: "root"
-      when: network_bridge is defined
+      when: network_bridge_interface is defined
 
     - name: "Configure wifi connection"
       ansible.builtin.template:
diff --git a/roles/network/templates/bridge.nmconnection.j2 b/roles/network/templates/bridge.nmconnection.j2
index 2e8bf23c..013acd6a 100644
--- a/roles/network/templates/bridge.nmconnection.j2
+++ b/roles/network/templates/bridge.nmconnection.j2
@@ -1,7 +1,7 @@
 [connection]
-id={{ network_bridge }}
+id=vmbr0
 type=bridge
-interface-name={{ network_bridge }}
+interface-name=vmbr0
 autoconnect=true
 
 [bridge]
diff --git a/roles/network/templates/eth0-connection.nmconnection.j2 b/roles/network/templates/eth0-connection.nmconnection.j2
index 6a6481c4..d6deea34 100644
--- a/roles/network/templates/eth0-connection.nmconnection.j2
+++ b/roles/network/templates/eth0-connection.nmconnection.j2
@@ -2,16 +2,18 @@
 id=ethernet
 type=ethernet
 autoconnect=true
-{% if network_bridge is defined %}
-controller={{ network_bridge }}
-port-type=bridge
+{% if network_bridge_interface is defined %}
+interface-name={{ network_bridge_interface }}
+# NOTE: master/slave-type keyfile keys deprecated in NM 1.46, replaced by controller/port-type
+master=vmbr0
+slave-type=bridge
 {% endif %}
 
 [ethernet]
 cloned-mac-address=permanent
 
 [ipv4]
-{% if network_bridge is defined %}
+{% if network_bridge_interface is defined %}
 method=disabled
 {% elif network_ipv4_address is defined %}
 method=manual
@@ -26,7 +28,7 @@ method=auto
 
 [ipv6]
 addr-gen-mode=default
-{% if network_bridge is defined %}
+{% if network_bridge_interface is defined %}
 method=disabled
 {% elif network_ipv6_address is defined %}
 method=manual
-- 
cgit v1.2.3