From e29ccfa18e51059897da5657f3b577ea28617f53 Mon Sep 17 00:00:00 2001 From: Ahmed AbdelHalim Date: Mon, 11 Aug 2025 00:32:04 +0200 Subject: Simplify playbook by requiring the required_for_boot tag on roles Instead of optimizing for task execution for boot, it's simpler and almost as equally safe (if not even more) to require the role for boot instead of requiring each of it's needed tasks. This will also prevent having internal bugs because a set fact wasn't required for boot and didn't add the info (similar to the fix in commit: 9f72c58) --- roles/network/tasks/install-debian.yml | 4 ---- 1 file changed, 4 deletions(-) (limited to 'roles/network/tasks/install-debian.yml') diff --git a/roles/network/tasks/install-debian.yml b/roles/network/tasks/install-debian.yml index 74c527d5..6b5455a8 100644 --- a/roles/network/tasks/install-debian.yml +++ b/roles/network/tasks/install-debian.yml @@ -5,7 +5,6 @@ pkg: "{{ network_packages }}" state: "present" update_cache: true - tags: [required_for_boot] - name: "Set network_default_services facts" ansible.builtin.set_fact: @@ -14,7 +13,6 @@ - "avahi-daemon" - "networking" - "wpa_supplicant" - tags: [required_for_boot] - name: "Stop/Disable conflicting services" become: true @@ -34,7 +32,6 @@ changed_when: true when: ansible_is_chroot # noqa: command-instead-of-module module doesn't work inside chroot - tags: [required_for_boot] - name: "Ensure avahi packages are removed" become: true @@ -45,4 +42,3 @@ state: "absent" autoremove: true purge: true - tags: [required_for_boot] -- cgit v1.2.3