Revert adding user.js config

Since the configs were mainly to control UI pref (which is not usable
with user.js, as it will always override manual customization)
The rest of the features provided by user.js isn't necessary and are
already covered by policies.

So for now, I'm removing this user.js integration, maybe revisit it
later if it's proven to be useful, ATM, it complicates and brittles the
setup without providing any additional value.

1 files changed, 1 insertions, 31 deletions

diff --git a/roles/firefox/meta/argument_specs.yml b/roles/firefox/meta/argument_specs.yml
index 13f9f61d..ef16d594 100644
--- a/roles/firefox/meta/argument_specs.yml
+++ b/roles/firefox/meta/argument_specs.yml
@@ -1,6 +1,6 @@
 ---
 # NOTE: The defaults below are sensible role defaults and are not meant to be changed directly.
-# Use the override variables (firefox_policies_override, firefox_extra_extensions, firefox_user_prefs_override)
+# Use the override variables (firefox_policies_override, firefox_extra_extensions)
 # to customize behavior.
 # But also you can change these defaults directly.
 argument_specs:
@@ -16,10 +16,6 @@ argument_specs:
         type: "dict"
         description: "Extra firefox extensions to install via policies (added to the default extensions)"
         default: {}
-      firefox_user_prefs_override:
-        type: "dict"
-        description: "Override role's default user pref (user.js preferences for Firefox profile)"
-        default: {}
       firefox_default_extensions:
         # Default extensions to be installed in Firefox via policies
         # - uBlock Origin
@@ -140,29 +136,3 @@ argument_specs:
             FirfoxLabs: false
           UseSystemPrintDialog: true
           VisualSearchEnabled: true
-      firefox_default_user_prefs:
-        type: "dict"
-        description: "Default (sensible) user.js preference for Firefox"
-        default:
-          "browser.newtabpage.enabled": false
-          "browser.aboutConfig.showWarning": false
-          "browser.tabs.closeWindowWithLastTab": false
-          "privacy.trackingprotection.enabled": true
-          "privacy.trackingprotection.socialtracking.enabled": true
-          "privacy.donottrackheader.enabled": true
-          "dom.security.https_only_mode": true
-          "dom.security.https_only_mode_ever_enabled": true
-          "datareporting.healthreport.uploadEnabled": false
-          "datareporting.policy.dataSubmissionEnabled": false
-          "toolkit.telemetry.unified": false
-          "toolkit.telemetry.enabled": false
-          "toolkit.telemetry.server": ""
-          "toolkit.telemetry.archive.enabled": false
-          "toolkit.telemetry.newProfilePing.enabled": false
-          "toolkit.telemetry.shutdownPingSender.enabled": false
-          "toolkit.telemetry.updatePing.enabled": false
-          "toolkit.telemetry.bhrPing.enabled": false
-          "toolkit.telemetry.firstShutdownPing.enabled": false
-          "extensions.pocket.enabled": false
-          "sidebar.verticalTabs": true
-          "sidebar.verticalTabs.dragToPinPromo.dismissed": true